Added support to honor python imports rules for pex_binaries.#35
Open
srikalyan wants to merge 1 commit intobenley:masterfrom
Open
Added support to honor python imports rules for pex_binaries.#35srikalyan wants to merge 1 commit intobenley:masterfrom
srikalyan wants to merge 1 commit intobenley:masterfrom
Conversation
Author
|
I could not find a easy way to add this info for pex binary and other pex artifcats. If you could provide some tips, I can get it up and running |
Owner
|
Awesome, thank you for the pull request! I'm not sure I understand what you mean by "add this info for pex binary and other pex artifacts" - can you elaborate? |
Author
|
This current implementation only supports pex_binary. Does not support imports for pex_library, pex_test, pex_pytest. Perhaps a pointer can definitely help me add that support. |
Owner
|
Sorry for the delay - I haven't forgotten about this, but I haven't had time to return to it just yet. |
Owner
|
I guess we're still waiting for bazelbuild/bazel#2791 to get merged... |
Contributor
|
This has the same motivation as #42 . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bazelbuild/bazel#2791 should provide the imports information to skylark and this review uses that information (provided in skylark) to build pex_binaries that honor import.
This change is